Improve whitespace in compact mode #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, could you add a line to the CHANGELOG.md file? That way we can mention it in the releasenotes for everyone. |
|
@SMillerDev Done! |
|
And one last thing is the DCO check, https://github.com/nextcloud/news/pull/1017/checks?check_run_id=1636327257 |
Signed-off-by: heyarne <[email protected]>
Signed-off-by: heyarne <[email protected]>
Signed-off-by: heyarne <[email protected]>
rrrnld
force-pushed
the
feature/improve-subtitle-whitespace
branch
from
89a07b7 to
df74333
Compare
|
@SMillerDev Made sure to sign off the commits :) |
Merged
Grotax
added a commit
that referenced
this pull request
Jan 12, 2021
Changed - Remove outdated feed DB code - add background & hover for entries - Improve spacing of open articles in compact mode (#1017) Fixed - `MissingNamedParameter` exception after upgrading to NC 21 beta5 (#1030) Signed-off-by: Benjamin Brahmer <[email protected]>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated feed DB code - add background & hover for entries - Improve spacing of open articles in compact mode (nextcloud#1017) Fixed - `MissingNamedParameter` exception after upgrading to NC 21 beta5 (nextcloud#1030) Signed-off-by: Benjamin Brahmer <[email protected]> Signed-off-by: Marco Nassabain <[email protected]>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated feed DB code - add background & hover for entries - Improve spacing of open articles in compact mode (nextcloud#1017) Fixed - `MissingNamedParameter` exception after upgrading to NC 21 beta5 (nextcloud#1030) Signed-off-by: Benjamin Brahmer <[email protected]> Signed-off-by: Marco Nassabain <[email protected]>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated feed DB code - add background & hover for entries - Improve spacing of open articles in compact mode (nextcloud#1017) Fixed - `MissingNamedParameter` exception after upgrading to NC 21 beta5 (nextcloud#1030) Signed-off-by: Benjamin Brahmer <[email protected]> Signed-off-by: Marco Nassabain <[email protected]>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Remove outdated feed DB code - add background & hover for entries - Improve spacing of open articles in compact mode (nextcloud#1017) Fixed - `MissingNamedParameter` exception after upgrading to NC 21 beta5 (nextcloud#1030) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since introducing the zebra-striped headlines, the subtitle and utility bar spacing was noticably off. This commit fixes that.
Before:
After:
