Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Update psalm definition and dependency list #1083

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

SMillerDev
Copy link
Contributor

Signed-off-by: Sean Molenaar [email protected]

This will make psalm pass with more v21 code, and clear out some undefined classes issues in the run.

Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
However I'm not sure why doctrine/dbal was added to the dev dependencies since it's already supplied by the NC server.

@SMillerDev
Copy link
Contributor Author

That's why I added it as a dev dependency. For development composer will pull it in and otherwise the server will.

@SMillerDev SMillerDev merged commit cb10dd1 into nextcloud:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants