Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: Remove unused fields #1126

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

SMillerDev
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1126 (5a48d44) into master (f9fde62) will decrease coverage by 2.69%.
The diff coverage is 71.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1126      +/-   ##
============================================
- Coverage     72.07%   69.37%   -2.70%     
- Complexity      681      742      +61     
============================================
  Files            58       74      +16     
  Lines          2417     2704     +287     
============================================
+ Hits           1742     1876     +134     
- Misses          675      828     +153     
Impacted Files Coverage Δ Complexity Δ
lib/Command/Updater/AllFeeds.php 0.00% <0.00%> (ø) 4.00 <1.00> (ø)
lib/Config/FetcherConfig.php 0.00% <0.00%> (ø) 6.00 <6.00> (-6.00)
lib/Config/LegacyConfig.php 0.00% <0.00%> (ø) 7.00 <7.00> (?)
lib/Controller/AdminController.php 100.00% <ø> (ø) 5.00 <0.00> (+2.00)
lib/Controller/ApiController.php 72.72% <ø> (-5.06%) 5.00 <0.00> (+1.00) ⬇️
lib/Controller/ApiPayloadTrait.php 90.00% <ø> (ø) 5.00 <0.00> (?)
lib/Controller/Controller.php 88.88% <ø> (ø) 4.00 <0.00> (?)
lib/Controller/Exceptions/NotLoggedInException.php 0.00% <ø> (ø) 1.00 <0.00> (?)
lib/Controller/ExportController.php 100.00% <ø> (ø) 5.00 <0.00> (ø)
lib/Controller/FeedApiController.php 96.72% <ø> (-3.28%) 20.00 <0.00> (+2.00) ⬇️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7838e...5a48d44. Read the comment docs.

tests/Unit/Db/FolderTest.php Outdated Show resolved Hide resolved
tests/Unit/Db/FolderTest.php Show resolved Hide resolved
lib/Db/Item.php Outdated Show resolved Hide resolved
@SMillerDev SMillerDev force-pushed the chore/remove_unused_fields branch from 5a48d44 to 415370d Compare February 4, 2021 21:56
@SMillerDev SMillerDev added this to the 15.3.0 milestone Feb 4, 2021
Signed-off-by: Sean Molenaar <[email protected]>
@SMillerDev SMillerDev force-pushed the chore/remove_unused_fields branch from 415370d to 2599a65 Compare February 4, 2021 22:12
@SMillerDev SMillerDev merged commit 6e9e251 into nextcloud:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants