-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: add feed search #1402
Merged
Grotax
merged 1 commit into
nextcloud:master
from
SMillerDev:feature/search/feed_search
Jun 16, 2021
Merged
Search: add feed search #1402
Grotax
merged 1 commit into
nextcloud:master
from
SMillerDev:feature/search/feed_search
Jun 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c30fc4c
to
d32efa7
Compare
anoymouserver
requested changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SearchProvider still needs to be registered for it to work.
Everything else works as expected.
diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
index ea7beeae5..6917fe747 100644
--- a/lib/AppInfo/Application.php
+++ b/lib/AppInfo/Application.php
@@ -23,6 +23,7 @@ use OCA\News\Config\LegacyConfig;
use OCA\News\Config\FetcherConfig;
use OCA\News\Hooks\UserDeleteHook;
use OCA\News\Search\FolderSearchProvider;
+use OCA\News\Search\FeedSearchProvider;
use OCP\AppFramework\Bootstrap\IBootContext;
use OCP\AppFramework\Bootstrap\IBootstrap;
@@ -83,6 +84,7 @@ class Application extends App implements IBootstrap
});
$context->registerSearchProvider(FolderSearchProvider::class);
+ $context->registerSearchProvider(FeedSearchProvider::class);
$context->registerEventListener(BeforeUserDeletedEvent::class, UserDeleteHook::class);
🤦 thanks. I'll update this later |
Signed-off-by: Sean Molenaar <[email protected]>
d32efa7
to
1d0c2c5
Compare
Finally had some time to add it to Application.php and also removed some left-over statements for the config file loading. |
anoymouserver
approved these changes
Jun 15, 2021
Grotax
added a commit
that referenced
this pull request
Jun 16, 2021
Changed - added feed search (#1402) Fixed - removed reference for deleted repair-steps (#1399) - Fix NotNullConstraintViolation when sharing news items with users (#1406) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jun 16, 2021
Changed - added feed search (#1402) Fixed - removed reference for deleted repair-steps (#1399) - Fix NotNullConstraintViolation when sharing news items with users (#1406) Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Jul 1, 2021
There are no additional changes compared to the latest beta. Changed - News now requires a 64bit OS - v2 API implementation (folder part) - Implemented sharing news items between nextcloud users (#1191) - Updated the news items table in DB to include sharer data (#1191) - Added route for sharing news items (#1191) - Added share data in news items serialization (#1191) - Added tests for the news items share feature (#1191) - Added sharing articles with nextcloud users (#1217) - Added sharing articles on social media (Facebook, Twitter) or mail (#1217) - Allow installation on Nextcloud v22 - Remove deprecated API endpoints and occ command (#935) - /api/v1-2/user - /api/v1-2/user/avatar - ./occ news:updater:all-feeds - added feed search (#1402) Fixed - allow calling `/items?getRead=false` without a feed/folder (#1380 #1356) - newestId does not return newest ID but last updated (#1339) - removed reference for deleted repair-steps (#1399) - Fix NotNullConstraintViolation when sharing news items with users (#1406) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jul 4, 2021
There are no additional changes compared to the latest beta. Changed - News now requires a 64bit OS - v2 API implementation (folder part) - Implemented sharing news items between nextcloud users (#1191) - Updated the news items table in DB to include sharer data (#1191) - Added route for sharing news items (#1191) - Added share data in news items serialization (#1191) - Added tests for the news items share feature (#1191) - Added sharing articles with nextcloud users (#1217) - Added sharing articles on social media (Facebook, Twitter) or mail (#1217) - Allow installation on Nextcloud v22 - Remove deprecated API endpoints and occ command (#935) - /api/v1-2/user - /api/v1-2/user/avatar - ./occ news:updater:all-feeds - added feed search (#1402) Fixed - allow calling `/items?getRead=false` without a feed/folder (#1380 #1356) - newestId does not return newest ID but last updated (#1339) - removed reference for deleted repair-steps (#1399) - Fix NotNullConstraintViolation when sharing news items with users (#1406) Signed-off-by: Benjamin Brahmer <[email protected]>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - added feed search (nextcloud#1402) Fixed - removed reference for deleted repair-steps (nextcloud#1399) - Fix NotNullConstraintViolation when sharing news items with users (nextcloud#1406) Signed-off-by: Benjamin Brahmer <[email protected]>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
There are no additional changes compared to the latest beta. Changed - News now requires a 64bit OS - v2 API implementation (folder part) - Implemented sharing news items between nextcloud users (nextcloud#1191) - Updated the news items table in DB to include sharer data (nextcloud#1191) - Added route for sharing news items (nextcloud#1191) - Added share data in news items serialization (nextcloud#1191) - Added tests for the news items share feature (nextcloud#1191) - Added sharing articles with nextcloud users (nextcloud#1217) - Added sharing articles on social media (Facebook, Twitter) or mail (nextcloud#1217) - Allow installation on Nextcloud v22 - Remove deprecated API endpoints and occ command (nextcloud#935) - /api/v1-2/user - /api/v1-2/user/avatar - ./occ news:updater:all-feeds - added feed search (nextcloud#1402) Fixed - allow calling `/items?getRead=false` without a feed/folder (nextcloud#1380 nextcloud#1356) - newestId does not return newest ID but last updated (nextcloud#1339) - removed reference for deleted repair-steps (nextcloud#1399) - Fix NotNullConstraintViolation when sharing news items with users (nextcloud#1406) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feed search
Results are like: