Fix only one item marked as read by Feed API #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Brahmer <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Mar 9, 2022
Fixed - Fix only one item marked as read by Feed API (#1687) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Mar 9, 2022
Fixed - Fix only one item marked as read by Feed API (#1687) Signed-off-by: Benjamin Brahmer <[email protected]>
I just tested with the 18.0.1 release. |
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Fixed - Fix only one item marked as read by Feed API (nextcloud#1687) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at #1544
And investigated the code a bit, it seems like the wrong service was called since we introduced the new controllers.
It didn't throw any errors because both read functions have the same signature but the parameters are used in a totally different way ...
Not tested yet only based on logical reading.