Add psalm for static code analysis #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a 100% sure how useful this will be in the beginning as right now we have many errors according to psalm, some of them might be invalid though. |
|
The check doesn't seem to be run yet? |
|
No apparently not, maybe there is a syntax error because the changelog enforcer was also inforced on the or itself |
|
yea it was a yaml lint error :) added a plugin to my editor now |
|
I think I'd want to fix the reported issues here before merging this. |
|
Sure, I didn't want to integrate that into this pr. Partly because I'm not sure how to fix it |
Signed-off-by: Benjamin Brahmer <[email protected]>
SMillerDev
approved these changes
Jan 7, 2021
anoymouserver
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the static code analyzer psalm based on https://docs.nextcloud.com/server/latest/developer_manual//digging_deeper/continuous_integration.html