Don't overwrite an existing mail_smtpmode if it is not "PHP" #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwriting the value `SMTP` is probably not the best idea. `SMTP` settings are done manually as required. They should not be disabled or overwritten.
TomTurnschuh
referenced
this pull request
Sep 17, 2018
PHP seems to be no longer supported in Nextcloud 14. This modification might need further testing in different environments.
TomTurnschuh
changed the title
|
Thanks good catch. You forgot to PR against |
|
This time I went for the master branch on purpose. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwriting the value
SMTPis probably not the best idea.SMTPsettings are done manually as required. They should not be disabled or overwritten.