Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased modsecurity bodynofileslimit so larger files can be synced #993

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

Iolaum
Copy link
Contributor

@Iolaum Iolaum commented Sep 8, 2019

Temporary(?) fix to #959

Needs testing. I added functionality in update.sh to update the config for people who already have modsecurity running, please check that I haven't overlooked something (or misunderstood chow check_distro works). The intent is that the fix would only apply to people who are in buster and have enabled, at some point, modsecurity.

People who enable modsecurity for the first time get the updated config file.

@Iolaum
Copy link
Contributor Author

Iolaum commented Sep 8, 2019

Minor note:

I tried testing my PR with

$ sudo ncp-update Iolaum:dev1
INFO: updating to development branch 'Iolaum:dev1'
Downloading updates
warning: Could not find remote branch Iolaum:dev1 to clone.
fatal: Remote branch Iolaum:dev1 not found in upstream origin
No internet connectivity

but it looks like it's not considered a branch by github. Not sure if there's another way to test it through the ncp-update process. I 'll look into it when I can.

update.sh Outdated Show resolved Hide resolved
@nachoparker
Copy link
Member

many thanks for this. I can merge it to devel so we can both test it with ncp-update devel once it's ready (or any other branch)

@nachoparker nachoparker force-pushed the devel branch 2 times, most recently from 6c62d01 to c1e1b65 Compare September 10, 2019 03:57
nachoparker and others added 2 commits September 10, 2019 10:27
@Iolaum
Copy link
Contributor Author

Iolaum commented Sep 10, 2019

Refactored the code per to your suggestions and re applied commits on top of current devel branch.

@nachoparker nachoparker merged commit 4019adb into nextcloud:devel Sep 11, 2019
@nachoparker
Copy link
Member

looks good, thanks. I merged it into devel, so it can be tested with ncp-update devel

nachoparker pushed a commit that referenced this pull request Sep 11, 2019
@Iolaum
Copy link
Contributor Author

Iolaum commented Sep 11, 2019

@nachoparker Tested PR with sudo ncp-update devel and it worked. A video file that wasn't syncing before (reverted my manual fix) did sync afterwards.

@nachoparker
Copy link
Member

great, many thanks!!

nachoparker pushed a commit that referenced this pull request Sep 12, 2019
nachoparker pushed a commit that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants