Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Kotlin to 1.8.10 #1698

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Bump Kotlin to 1.8.10 #1698

merged 1 commit into from
Mar 27, 2023

Conversation

tobiasKaminsky
Copy link
Member

Rebase once codeQL is working with 1.8.10.

AlvaroBrey
AlvaroBrey approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@AlvaroBrey AlvaroBrey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful not to merge this; it will pass CI as there is no Kotlin code in main for now; but it's not compatible yet

@AlvaroBrey AlvaroBrey marked this pull request as draft March 2, 2023 08:28
@AndyScherzinger
Copy link
Member

/rebase

@tobiasKaminsky
Copy link
Member Author

/rebase

@tobiasKaminsky
Bump Kotlin to 1.8.10
d2fe027 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
Copy link
Member Author

We now have Kotlin in it and still everything works :)

@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review March 27, 2023 08:54
@tobiasKaminsky tobiasKaminsky merged commit d96688e into main Mar 27, 2023
@tobiasKaminsky tobiasKaminsky deleted the bumpKotlin1.8.10 branch March 27, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey approved these changes

Assignees
No one assigned
Labels
3. to review don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @AndyScherzinger @AlvaroBrey