-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump com.android.tools.build:gradle from 7.4.2 to 8.0.0 #1764
build(deps): Bump com.android.tools.build:gradle from 7.4.2 to 8.0.0 #1764
Conversation
557dbba
to
0bbafbc
Compare
@stefan-niedermann I bumped all things neccessary to java17 for gradle8 - only remaining thing is tests failing for very fundamental thing where I expect it to be some kind of a java-version issue, maybe you have an idea?
|
Uhm, not ad hoc, sorry. I hope to find some time to check this this week. First guess: This is one of the little party where the SSO lib is used - maybe it has to do with configurations there? Maybe after merging #1771 the issue will vanish? 🤷 |
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
d7be95b
to
6531949
Compare
Unfortunately, no :( |
This comment was marked as resolved.
This comment was marked as resolved.
Oh boy, I think I know the cause. The SSO library uses some hacky way to instanciate Updating the user project to AGP 8 will use Java 17 which makes it impossible to instantiate |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Moving the discussion to nextcloud/Android-SingleSignOn#541 to not clutter this PR. |
A newer version of com.android.tools.build:gradle exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
superseeded by #1932 |
superseeded by #1940 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps com.android.tools.build:gradle from 7.4.2 to 8.0.0.
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)