Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump com.android.tools.build:gradle from 7.4.2 to 8.0.0 #1764

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2023

Bumps com.android.tools.build:gradle from 7.4.2 to 8.0.0.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added 3. to review dependencies Pull requests that update a dependency file labels Apr 14, 2023
@AndyScherzinger AndyScherzinger force-pushed the dependabot/gradle/com.android.tools.build-gradle-8.0.0 branch 3 times, most recently from 557dbba to 0bbafbc Compare April 17, 2023 13:17
@AndyScherzinger
Copy link
Member

@stefan-niedermann I bumped all things neccessary to java17 for gradle8 - only remaining thing is tests failing for very fundamental thing where I expect it to be some kind of a java-version issue, maybe you have an idea?

it.niedermann.owncloud.notes.persistence.ApiProviderTest > testGetNotesAPI[24] FAILED
    java.lang.ExceptionInInitializerError at ApiProviderTest.java:67
        Caused by: java.lang.reflect.InaccessibleObjectException at ApiProviderTest.java:67

it.niedermann.owncloud.notes.persistence.ApiProviderTest > testGetNotesAPI FAILED
    java.lang.ExceptionInInitializerError at ApiProviderTest.java:67
        Caused by: java.lang.reflect.InaccessibleObjectException at ApiProviderTest.java:67

it.niedermann.owncloud.notes.persistence.ApiProviderTest > testGetOcsAPI[24] FAILED
    java.lang.NoClassDefFoundError at ApiProviderTest.java:41

it.niedermann.owncloud.notes.persistence.ApiProviderTest > testGetOcsAPI FAILED
    java.lang.NoClassDefFoundError at ApiProviderTest.java:41

@stefan-niedermann
Copy link
Member

Uhm, not ad hoc, sorry. I hope to find some time to check this this week.

First guess: This is one of the little party where the SSO lib is used - maybe it has to do with configurations there? Maybe after merging #1771 the issue will vanish? 🤷

Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the dependabot/gradle/com.android.tools.build-gradle-8.0.0 branch from d7be95b to 6531949 Compare April 17, 2023 14:08
@AndyScherzinger
Copy link
Member

Maybe after merging #1771 the issue will vanish? 🤷

Unfortunately, no :(

@stefan-niedermann

This comment was marked as resolved.

@stefan-niedermann
Copy link
Member

Oh boy, I think I know the cause. The SSO library uses some hacky way to instanciate Void using reflection - this was only possible until Java 14(?) I think.

Updating the user project to AGP 8 will use Java 17 which makes it impossible to instantiate Void. We'll need to fix this first.

nextcloud/Android-SingleSignOn@e19aae1 by @desperateCoder

@stefan-niedermann

This comment was marked as off-topic.

@stefan-niedermann

This comment was marked as off-topic.

@stefan-niedermann
Copy link
Member

Moving the discussion to nextcloud/Android-SingleSignOn#541 to not clutter this PR.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 2, 2023

A newer version of com.android.tools.build:gradle exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@AndyScherzinger
Copy link
Member

superseeded by #1932

@AndyScherzinger
Copy link
Member

superseeded by #1940

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 21, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@AndyScherzinger AndyScherzinger deleted the dependabot/gradle/com.android.tools.build-gradle-8.0.0 branch January 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants