Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): AGP 8, Java 17, Kotlin 1.9.22, SSO 1.0.0 #1979

Merged
merged 9 commits into from
Jan 21, 2024
Merged

chore(deps): AGP 8, Java 17, Kotlin 1.9.22, SSO 1.0.0 #1979

merged 9 commits into from
Jan 21, 2024

Conversation

stefan-niedermann
Copy link
Member

@stefan-niedermann stefan-niedermann commented Jan 20, 2024 •
edited
Loading

  • Successfully tested on a physical Android 13 device.
  • Successfully tested on a virtual Android 14 device:
    Launch, import, edit and sync work fine.
  • Considering the quite big platform changes (AGP & Java), I recommend you to test the changes on an Android 7.0 device (current minSdk is 24).

@stefan-niedermann stefan-niedermann marked this pull request as ready for review January 20, 2024 10:37
AndyScherzinger
AndyScherzinger reviewed Jan 20, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise, thanks for the work @stefan-niedermann

2 things, one cosmetic the other one Android 14 related

  • we can bump gradle to 8.5 I think
  • Android 14 will need to be checked in case Notes uses foreground services which may lead to issues due to the target = 34 bump

@AndyScherzinger AndyScherzinger self-requested a review January 21, 2024 15:07
AndyScherzinger
AndyScherzinger approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and also successfully testes on Android 13 physical device 👍

stefan-niedermann and others added 9 commits January 21, 2024 16:08
@stefan-niedermann @AndyScherzinger
chore(deps): AGP 8, Java 17, Kotlin 1.9.22, SSO 1.0.0
064d86d 
Signed-off-by: Stefan Niedermann <[email protected]>
@stefan-niedermann @AndyScherzinger
chore: Use enhanced switch and pattern variables
fc827d7 
Signed-off-by: Stefan Niedermann <[email protected]>
@stefan-niedermann @AndyScherzinger
fix(lint): Fix 80 character line issues
beaf014 
Signed-off-by: Stefan Niedermann <[email protected]>
@stefan-niedermann @AndyScherzinger
fix(lint): Fix remaining 80 character line issue
8efa364 
Signed-off-by: Stefan Niedermann <[email protected]>
@stefan-niedermann @AndyScherzinger
chore(deps): Use Gradle 8.5 and target Robolectric to API 34
189f54f 
Signed-off-by: Stefan Niedermann <[email protected]>
@stefan-niedermann @AndyScherzinger
chore(deps): Update dependencies and fix API changes
42d56e4 
Signed-off-by: Stefan Niedermann <[email protected]>
@stefan-niedermann @AndyScherzinger
chore(deps): Update dependencies
0318c97 
Signed-off-by: Stefan Niedermann <[email protected]>
@AndyScherzinger
flavorDimensions upgrade: now a list not a string
e63eca9 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
bump mockito from 5.7.0 to 5.9.0
adf1a21 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger added this to the 4.2.0 milestone Jan 21, 2024
@AndyScherzinger AndyScherzinger merged commit 76f943a into main Jan 21, 2024
13 checks passed
@AndyScherzinger AndyScherzinger deleted the agp-8 branch January 21, 2024 15:18
@AndyScherzinger AndyScherzinger mentioned this pull request Jan 21, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review feedback-requested
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stefan-niedermann @AndyScherzinger