Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Nextcloud 20 #599

Merged
merged 7 commits into from
Sep 15, 2020
Merged

Migrate to Nextcloud 20 #599

merged 7 commits into from
Sep 15, 2020

Conversation

korelstar
Copy link
Member

@korelstar korelstar commented Aug 27, 2020 •
edited
Loading

  • require Nextcloud 20
  • migrate to PSR-3 Logger Interface
  • migrate to new Nextcloud app bootstrap
  • add constant Application::APP_ID (best practice for Nextcloud apps)
  • use OCP\ITags::TAG_FAVORITE (was introduced in NC19)
  • simplify global functions (directly use small mixin)
  • fix CI tests for unpublished server version (use master branch if stableXX does not exist yet)

@korelstar korelstar added the maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc. label Aug 27, 2020
@korelstar korelstar added this to the 3.7.0 milestone Aug 27, 2020
@korelstar korelstar marked this pull request as ready for review September 15, 2020 18:49
@korelstar korelstar merged commit 0de90c4 into master Sep 15, 2020
@korelstar korelstar deleted the nc20 branch September 15, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@korelstar