Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to have all categories always visible in the navigation list #839

Closed

Conversation

joachimeichborn
Copy link
Contributor

I found it very uncomfortable to work with categories as they are always collapsed whenever I switch between them in the navigation list. Therefore I have added an option to the settings to have them always visible. If this is turned off (Settings -> Display mode for categories -> Collapse categories) everything behaves as before. If it is turned on (Settings -> Display mode for categories -> Always show all categories) a list of all categories is always shown with the active category being highlighted.

Implementation wise I have extracted the existing categories list from NavigationCategoriesItem to NavigationCategoriesList. It is then either used inside NavigataionCategoriesItem to show the uncollapsed list as before or directly inside NavigationCategoriesList to show the always visible category list (depending on the chosen setting).

@stefan-niedermann
Copy link
Member

@korelstar wouldn't it make sense to rethink the default and simply show the categories? I agree that category usage is currently not optimal and in my opinion we could simply show them always without an option 🤷

@korelstar
Copy link
Member

I agree, too, that the current category handling is sub-optimal. But there is already a discussion on this, see #413. I apologize, that this is still not fixed (due to lack of time). But the goal is clear: We want to switch to a three-column layout using the standard components from nextcloud-vue:

With this goal in mind, I don't think that it is productive to introduce an interim solution like this PR. @joachimeichborn, I would appreciate very much if you could help with implementing the final solution! Maybe, you would like to extend this PR or start a new PR on this? That would be very cool!

@korelstar
Copy link
Member

Closing in favor of #842

@korelstar korelstar closed this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants