Use typed events #90
Merged
Use typed events #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChristophWurst
commented
Nov 19, 2019
•
ChristophWurst
commented
- Requires Add typed events for password_policy server#18019
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added a commit
to nextcloud/guests
that referenced
this pull request
Nov 19, 2019
Requires nextcloud/server#18019 Requires nextcloud/password_policy#90 Signed-off-by: Christoph Wurst <[email protected]>
This was referenced Nov 19, 2019
|
Can't we keep both events for now? |
Yes, but the old one uses the GenericEvent. Once that gets removed it will do 💥 |
Sure but it won't just be removed right. That will opnly happen with a symfony upgrade? for 18 it should just work or? |
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/typed-events
branch
from
d1c78bf to
8eaa090
Compare
|
Done |
rullzer
approved these changes
Nov 27, 2019
ChristophWurst
added a commit
to nextcloud/guests
that referenced
this pull request
Nov 27, 2019
Requires nextcloud/server#18019 Requires nextcloud/password_policy#90 Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added a commit
to nextcloud/guests
that referenced
this pull request
Nov 27, 2019
Requires nextcloud/server#18019 Requires nextcloud/password_policy#90 Signed-off-by: Christoph Wurst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.