Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.2.4.7/4.1 - "Photos settings" modal dialog - The toggle button "Enable squared photos view" receives keyboard focus, but it is not easily noticeable. It would be better to use a noticeable frame for focusing. (1) #1671

Closed
2 tasks
AndyScherzinger opened this issue Mar 2, 2023 · 0 comments · Fixed by nextcloud-libraries/nextcloud-vue#4176
Closed
2 tasks

[BITV] 9.2.4.7/4.1 - "Photos settings" modal dialog - The toggle button "Enable squared photos view" receives keyboard focus, but it is not easily noticeable. It would be better to use a noticeable frame for focusing. (1) #1671

AndyScherzinger opened this issue Mar 2, 2023 · 0 comments · Fixed by nextcloud-libraries/nextcloud-vue#4176
Assignees
@nfebe
Labels
1. to develop Accepted and waiting to be taken care of accessibility design Related to the design

Comments

@AndyScherzinger
Copy link
Member

  • Fix
  • Backport

7f1a8522565d214125291c78487d02e1

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-91f2646afa-v4-n1
@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility design Related to the design labels Mar 2, 2023
@nfebe nfebe self-assigned this May 20, 2023
nfebe added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue Jun 2, 2023
@nfebe
Add focus-visible style for NcCheckboxRadioSwitch
d82a8da 
Improve accesibility by making focus indicator visible.

Resolves : nextcloud/photos#1671

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe mentioned this issue Jun 2, 2023
Merged
2 tasks
nfebe added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue Jun 6, 2023
@nfebe
Add focus-visible style for NcCheckboxRadioSwitch
fa8c137 
Improve accesibility by making focus indicator visible.

Resolves : nextcloud/photos#1671

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue Jun 7, 2023
@nfebe
Add focus-visible style for NcCheckboxRadioSwitch
ea9c8ba 
Improve accesibility by making focus indicator visible.

Resolves : nextcloud/photos#1671

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue Jun 9, 2023
@nfebe
Add focus-visible style for NcCheckboxRadioSwitch
5ef76b3 
Improve accesibility by making focus indicator visible.

Resolves : nextcloud/photos#1671

Signed-off-by: fenn-cs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfebe nfebe

Labels
1. to develop Accepted and waiting to be taken care of accessibility design Related to the design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add focus-visible style for NcCheckboxRadioSwitch nextcloud-libraries/nextcloud-vue
2 participants
@AndyScherzinger @nfebe