-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] enh(a11y): Make privacy markup accessible #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically already works on 28 but as 28 is a11y target should we get these UX + a11y enhancements in @AndyScherzinger? |
435f4a2
to
b23a60a
Compare
/compile amend / |
b23a60a
to
6ad7266
Compare
AndyScherzinger
approved these changes
Nov 30, 2023
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit 9ec0632)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit 0e82334)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit dc96cab)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit 62d000c)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit f9c7bb2)
- Use with https://github.com/nextcloud/hmr_enabler Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit 231e2ec)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit 74a7da9)
- Migrate to new @nextcloud/vue API Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit b411e6f)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit 10b93e5)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit a02205e)
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit aa5ad53)
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
6ad7266
to
899c15f
Compare
Yes we should 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #992