Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Remove unused JS deps #316

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(deps): Remove unused JS deps #316

merged 1 commit into from
Jan 29, 2024

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen nickvergessen self-assigned this Jan 29, 2024
@nickvergessen nickvergessen requested a review from ShGKme January 29, 2024 08:50
ShGKme
ShGKme approved these changes Jan 29, 2024
View reviewed changes
Copy link

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the dependencies seems to be unneeded.

Not required, but I'd also remove their mentions in webpack.js just for cleanness 🧹

@nickvergessen
fix(deps): Remove unused JS deps
566a8d8 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

Not required, but I'd also remove their mentions in webpack.js just for cleanness 🧹

Thanks!

@nickvergessen nickvergessen merged commit 710f2aa into master Jan 29, 2024
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-unused-JS-deps branch January 29, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@nickvergessen nickvergessen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @ShGKme