Skip to content

Commit

Permalink
Update lib/private/AppFramework/Http/Request.php
Browse files Browse the repository at this point in the history
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
susnux and nickvergessen authored Jan 27, 2024
1 parent a61844a commit 1401506
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/private/AppFramework/Http/Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,9 @@ protected function isTrustedProxy($trustedProxies, $remoteAddress) {
try {
return IpUtils::checkIp($remoteAddress, $trustedProxies);
} catch (\Throwable) {
// We can not log here as the logger is using `getRemoteAddress` which uses the function, so we would have a cyclic dependency
// We can not log to our log here as the logger is using `getRemoteAddress` which uses the function, so we would have a cyclic dependency
// Reaching this line means `trustedProxies` is in invalid format.
error_log('Nextcloud trustedProxies has malformed entries');
return false;
}
}
Expand Down

0 comments on commit 1401506

Please sign in to comment.