Skip to content

Commit

Permalink
Feat: update border radius variables
Browse files Browse the repository at this point in the history
Signed-off-by: Marco Ambrosini <[email protected]>
  • Loading branch information
marcoambrosini committed Jul 31, 2024
1 parent 6a0edef commit bf2b8a0
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions apps/theming/lib/Themes/DefaultTheme.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,22 @@ public function getCSSVariables(): array {
// Border width for input elements such as text fields and selects
'--border-width-input' => '1px',
'--border-width-input-focused' => '2px',
'--border-radius' => '3px',

// Border radii (new values)
// See url on how to use
'--border-radius-small' => '4px', // For smaller elements
'--border-radius-element' => '8px', // For normal elements like buttons and inputs
'--border-radius-container' => '12px', // For smaller containers like action menus
'--border-radius-container-large' => '16px', // For bigger containers like body or modals

// Border radii (deprecated)
'--border-radius' => '4px',
'--border-radius-large' => '10px',
'--border-radius-rounded' => '28px',
'--border-radius-element' => '8px',
// pill-style button, value is large so big buttons also have correct roundness
'--border-radius-pill' => '100px',
'--border-radius-pill' => '100px',

// Big containers border radius, used for the body container
'--border-radius-large' => '10px',

Check failure on line 189 in apps/theming/lib/Themes/DefaultTheme.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

DuplicateArrayKey

apps/theming/lib/Themes/DefaultTheme.php:189:4: DuplicateArrayKey: Key '--border-radius-large' already exists on array (see https://psalm.dev/151)

Check failure

Code scanning / Psalm

DuplicateArrayKey Error

Key '--border-radius-large' already exists on array

'--default-clickable-area' => '34px',
'--clickable-area-large' => '48px',
Expand Down

0 comments on commit bf2b8a0

Please sign in to comment.