Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new search modal completely broken on mobile #41422

Closed
szaimen opened this issue Nov 13, 2023 · 4 comments · Fixed by #42776
Closed

new search modal completely broken on mobile #41422

szaimen opened this issue Nov 13, 2023 · 4 comments · Fixed by #42776
Assignees
@nfebe
Labels
accessibility design Design, UI, UX, etc.
Milestone
Nextcloud 29

Comments

@szaimen
Copy link
Contributor

szaimen commented Nov 13, 2023

See
image

cc @fenn-cs @marcoambrosini @JuliaKirschenheuter
@szaimen szaimen added design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 13, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Nov 13, 2023
@szaimen szaimen moved this to 🧭 Planning evaluation (don't pick) in 📁 Files team Nov 13, 2023
@szaimen szaimen moved this to 🧭 Planning evaluation / ideas in 🖍 Design team Nov 13, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@jancborchardt
Copy link
Member

Closing this as it is tracked in the #41381 already :)

@jancborchardt jancborchardt reopened this Dec 12, 2023
@nfebe nfebe mentioned this issue Dec 22, 2023
Closed
22 tasks
@nfebe
Copy link
Contributor

nfebe commented Dec 22, 2023

After a re-base I am realizing some updates to the modal component itself has resolved the responsiveness issue for master

Screenshot from 2023-12-22 18-18-21

@susnux please can you confirm?

@susnux
Copy link
Contributor

susnux commented Jan 22, 2024

@fenn-cs only for master, stable28 is still broken.

I think it will be fixed with #42776

@susnux susnux linked a pull request Jan 22, 2024 that will close this issue
[stable28] enh(UnifiedSearch): Keep the searchbar on top of the modal #42776
Merged
2 tasks
@nfebe nfebe mentioned this issue Feb 6, 2024
Closed
8 tasks
@nfebe nfebe removed the 1. to develop Accepted and waiting to be taken care of label Feb 6, 2024
@nfebe
Copy link
Contributor

nfebe commented Feb 6, 2024

Now fixed, see #42184

@nfebe nfebe closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfebe nfebe

Labels
accessibility design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging a pull request may close this issue.

[stable28] enh(UnifiedSearch): Keep the searchbar on top of the modal nextcloud/server
5 participants
@jancborchardt @susnux @blizzz @nfebe @szaimen