-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Caldav limit tag on initial sync causes incorrect Caldav error response. #48678
Comments
The Enabling debug mode should also populate I haven't looked too closely, but so far the changes introduced via #47770 & #47805 align most closely with your findings. |
Hi, I reproduced and looked in the nextcloud.log. This was what came up:
It seems indeed the Caldav "UnsupportedLimitOnInitialSyncException". Probably the changes in #47770 or #47805 changed this behavior and is now producing incorrect exception behavior for Caldav. In my opinion this is clearly a bug, and it might also potentially cause issues in other Caldav errors. We are receiving more and more mails from people affected by this behavior. Is this something that can be fixed soon ? |
cc @artonge do you have a tip for us how to prevent the default exception handler to overwrite our exception? |
Hmm, maybe we should display the exception for a given set of HTTP code. Probably here: server/apps/dav/lib/Files/ErrorPagePlugin.php Lines 61 to 88 in dc92218
Update that method to display or not the exception based on the HTTP code. |
Hi, |
The trouble with 30.0.1 is, that there is no switch back possible to 29.0.6 resp. 28.0.9. Therefore waiting for resolution is the only way forward. |
I have the same problem! |
I use the Android App OneCalender and get the Errormessage "This does not appear to be a valis CalDav server" when try to add my nextcloud account to it. It does work well with Thunderbird at Mac and Win. Would be nice to get it fixxed soon. Nextcloud 29.0.3 I am only a user, my Nextcloudadmin gave me that link to Github. Update: my Admin updated to 29.0.6 and its not working (Server got restart) |
I have multiple users that are running into this issue. |
I have the exact same problem. I had to reset my phone and start over with the calendar setup. Now I can´t get to run because of the limit error. |
On my Android tablet and on win11 the account setup seems to work. However syncing fails. |
This comment has been minimized.
This comment has been minimized.
The error is still present with the latest version of NC (30.0.2) and OneCalendar (5.6.0). Is there any guess when a patch/update/workaround will be available? Thanks! |
I've tried several apps that sync the calendar over caldav - none work with NextCloud right now. |
I did some further research and testing, and what I’ve found is that there is a bug in later versions of Nextcloud that prevents INITIAL syncing of caldav calendars. Those versions are 28.0.10 or higher, 29.0.7 or higher, and all versions of 30. Calendars where the initial sync was done in prior versions continue to sync correctly in the latest versions. I was able to confirm this by going back and installing version 29.0.6, migrating all my data and settings, syncing the calendars, then upgrading to 30.0.2 and everything worked correctly. Obviously doing a new install of 29.0.6 each time I want to add a new user with all that entails is a task I don’t want to do every week, but at least I have an option. Hopefully this will be fixed in the near future. |
Hello @kesselb @ChristophWurst @joshtrichards @artonge We (OneCalendar) have already received hundreds of mails from Nextcloud users facing this issue. Reading the comments above it also seems to fail with other CalDav clients. In reality probably thousands of users are affected who can no longer sync their Nextcloud calendars. It will be more and more affected users since it fails on initial sync if users try to connect their account again, or if they update their Nextcloud server. For OneCalendar it's difficult/tricky to build a temporary workaround since OneCalendar syncs with a lot of other servers as well, and it could create problems and loops for non-nextcloud users. Would it be possible to prioritise this issue ? Any estimates on when it will be solved ? |
This problem makes it very difficult to support calendars in Nextcloud at this time. Please make the nextcloud dav calendar server compliant with industry standards. All dav calendar clients I use are having issues connecting to nextcloud calendars when the initial connection did not happen on a lower version of nextcloud. |
Fix should be at #49004 (backports to 30, 29 and 28 will likelly happen in minor releases of January 2025). |
Hi there,
The patch was merged into master (the source for the current 31 version) but will be reverted due to issues discovered during testing the backports for versions 30, 29, and 28.1
That assumption is incorrect. Footnotes |
Thanks for the heads up. I'll pin my version for now then on beta 4. Out of curiosity, what has been the challenge in reverting things back to a working state? It's clearly something far more involved and complicated than we'd imagined.
I stand corrected, I got to say I'm surprised as I would have imagined businesses being of the opinion this is a significant issue. Like I said, for me, I just need to keep the wife happy. |
My instance upgraded to 3.0.5 last night. One Calendar still fails to sync. Stuff, [23/01/2025 09:15] <s:technical-details> </s:technical-details> Action: SyncReceiveCalendar XCalendarApp.CalDavProvider.DavAccountRequestException: net_http_message_not_success_statuscode_reason, 507, Insufficient Storage : <s:technical-details> </s:technical-details> ---> CodeSpark.Apps.Common.Net.Exceptions.HttpException: net_http_message_not_success_statuscode_reason, 507, Insufficient Storage Stuff, [23/01/2025 09:15] <s:technical-details> </s:technical-details> Inner exception: CodeSpark.Apps.Common.Net.Exceptions.HttpException: net_http_message_not_success_statuscode_reason, 507, Insufficient Storage Stuff, [23/01/2025 09:15] |
I am using the beta version 31 beta 4 with the new updated calendar version 3.0.5 |
@nouse4it thanks for confirming - I'd prefer to stay on stable for this instance but may consider on my other one although as I'm AIO, not sure if that's supported. tbh just amazed at how long Nextcloud are prepared to leave the (probably) most important collaboration app in an errored state. I suppose all the dev resource will be allocated towards AI "features" like in every other service today :-) |
My Admin updated Nextcloud to 3.0.5 and I tested it. Delete the Account in onecalender and added as new. Can add it and get an Initial sync Error. And Error every sync i try Bad. |
@nouse4it As far as I understand it, the patch to fix will be reverted in the v31 branch, so you need to stay on beta 4 now until the fix is applied again in the v31 branch. See this comment above and this PR |
Mhm, but this is only regarding the intial sync right? When the initial setup is done, there shouldn`t be any more problems? I just don´t want to run a beta version, if I don´t need to anymore |
I think going from v30 to v31 is a one way street, due to some database changes. So unless you have a backup and restore you're kind of stuck on beta until v31 stable (the branch of which has a pending PR to revert the fix, but hopefully will be reimplemented before the release of v31) It is all rather confusing... |
Good news for OneCalendar users: we are working on a workaround for this Nextcloud bug in OneCalendar. We still believe Nextcloud should fix this and make their product compliant with CalDAV standards, however it seems to have no priority and we have no faith this will be solved/fixed by Nextcloud anytime soon or maybe not at all. If all goes well, we hope to have a new OneCalendar release in 1-2 weeks that should work around this bug. |
Thank you @JeroenBer. This fix has priority and we have @kesselb work on this this week. If it were that simple, a fix would have landed a lot earlier. But be assured that we take this very serious. |
@ChristophWurst and @JeroenBer |
The OneCalendar workaround is gradually being rolled out:
So if you received a OneCalendar update with the version above (or higher) then please check and confirm if it works for you. |
@JeroenBer Update: Thank you |
I just updated through Android Play Store and the synchronisation worked! Thank you, much appreciated |
i cant believe you, in Androis is no version 5.7.1 avaiable. Its still 5.7.0. Its still broken on my phone! |
As I said before it's rolled out gradually, that means it's not directly available for all devices but might take up to a week. So please try again in a week and it should be available. |
unfortunatly the beta version program is full and I cant join, but no problem will wait another week for 5.7.1 - thanks for bugfixxing nextclouds bug |
Oh, UK first, for android updates :-) thanks for the screenshot, I am happy for you. |
Hello all. The update has arrived in Brazil. I have just updated the app in my Android to 5.7.1 and NC Calendar works perfectly now. Cheers. |
I have updated to OneCalendar 5.7.1 but I am still getting the error. Is there an extra step involved, eg removing the account then adding it back? |
I had to remove the account from OneCalendar and to create it new. After that it worked. |
I can confirm the workaround for this Nextcloud bug that OneCalendar implemented works fine. Glad to see OneCalendar provided a solution where Nextcloud did not do so for a long time. |
+1 from Hungary. The workaround solved the problem. No error message, calendar sync is just fine. |
The workaround solved the problem, without resetup of the account (but i did a lot with older versions). After update to 5.7.1 the sync worked well again! Thank you so much |
Is this prioritized fix included in the most recent stable release (v30.0.6)? |
@kesselb @ChristophWurst How is it looking for a february release? Not all of us use OneCalendar... |
I'm afraid the patches didn't make it into the February release. However, things are looking good so far, and unless we spot any additional issues, the patches will be included in the March release. Also, the current release candidate for 31 should already include them.
@MaggiWuerze Out of curiosity, which client are you using? |
Bug description
OneCalendar users are experiencing errors when syncing caldav calendars with Nextcloud. This used to be working.
As OneCalendar developer I tried to reproduce the problem and for the latest versions of 28,29 and 30 the Caldav response is no longer working correctly when
doing a initial sync.
Hereby an overview of which versions are working correct/incorrect:
Steps to reproduce
Sync caldav calendar data:
Request data
Actual response data (507):
Expected behavior
According to https://tools.ietf.org/html/rfc6578#section-3.11 the caldav server does not need to support limit tag but in that case the following 507 response data is expected:
Nextcloud Server version
28
Operating system
None
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
No response
List of activated Apps
No response
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
Perhaps there has been a minor update/fix of SabreDav that caused this problem in the newer 28/29/30 versions ?
The text was updated successfully, but these errors were encountered: