Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar invitation: use system default instead of sender's language as fallback #12020

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

georgehrke
Copy link
Member

fixes #11795

@rullzer This (partly) fixes #11795. It's better to use the instance language as a fallback, rather than the sender's language.

If there is a LANGUAGE parameter set for an Attendee in the calendar data, then it will always use that language. So to use the correct language of another user, this needs a modification in the calendar app (that's already planned).

@georgehrke georgehrke requested a review from rullzer October 24, 2018 16:44
@georgehrke georgehrke added this to the Nextcloud 15 milestone Oct 24, 2018
@georgehrke georgehrke added the 3. to review Waiting for reviews label Oct 24, 2018
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :)

Of course having it in my language will be an even more awesome improvement :D

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@blizzz blizzz merged commit 1293aff into master Oct 30, 2018
@blizzz blizzz deleted the bugfix/11795/calendar_invitation_fallback_lang branch October 30, 2018 21:05
@MorrisJobke
Copy link
Member

Backport this or not?

@MorrisJobke
Copy link
Member

Backport this or not?

cc @georgehrke

@georgehrke
Copy link
Member Author

extremely minor bug, so this is enough for 15 imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar invitation in senders language
4 participants