use OCP\EventDispatcher\Event over Symfony's deprecated Event #17568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
rullzer,
nickvergessen,
ChristophWurst,
icewind1991 and
juliusknorr
blizzz
added
2. developing
ChristophWurst
approved these changes
Oct 16, 2019
| use OCA\TwoFactorBackupCodes\Migration\CheckBackupCodes; | ||
| use OCA\TwoFactorBackupCodes\Provider\BackupCodesProvider; |
There was a problem hiding this comment.
it is unused, therefore removed. Or what do you mean?
There was a problem hiding this comment.
This is my nice cleanup emoji :)
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/move-away-from-deprecated-event
branch
from
77d679b to
e8095cf
Compare
|
@juliushaertl could you deign me a review maybe? |
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaves GenericEvent to be replaced