Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typed create user events #18028

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Add typed create user events #18028

merged 1 commit into from
Dec 3, 2019

Conversation

ChristophWurst
Copy link
Member

Discovered while working on nextcloud/mail#2259.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Nov 20, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Nov 20, 2019
@ChristophWurst ChristophWurst self-assigned this Nov 20, 2019
rullzer
rullzer approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. very elegant

@juliusknorr juliusknorr force-pushed the enhancement/user-create-events branch from af88adb to 6292c00 Compare November 21, 2019 18:22
@juliusknorr

This comment has been minimized.

Sign in to view
@rullzer

This comment has been minimized.

Sign in to view
@ChristophWurst ChristophWurst force-pushed the enhancement/user-create-events branch from 6292c00 to 04b098b Compare November 22, 2019 08:26
@rullzer rullzer force-pushed the enhancement/user-create-events branch 2 times, most recently from ad6bf0e to 12d6d87 Compare November 26, 2019 13:40
@rullzer
Copy link
Member

rullzer commented Nov 26, 2019

Tests do 💥

@rullzer rullzer force-pushed the enhancement/user-create-events branch 2 times, most recently from 2a0fe9e to 7ebc026 Compare November 29, 2019 08:14
@ChristophWurst ChristophWurst force-pushed the enhancement/user-create-events branch from 7ebc026 to f5d3fc2 Compare December 2, 2019 08:04
@ChristophWurst @rullzer
Add typed create user events
cc80339 
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the enhancement/user-create-events branch from f5d3fc2 to cc80339 Compare December 3, 2019 07:04
@rullzer rullzer merged commit 1d707cc into master Dec 3, 2019
@rullzer rullzer deleted the enhancement/user-create-events branch December 3, 2019 07:57
@ChristophWurst ChristophWurst mentioned this pull request Dec 11, 2019
Merged
@MorrisJobke
Copy link
Member

ref #14552

@MorrisJobke MorrisJobke mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @juliusknorr @rullzer @MorrisJobke