Add real events to load additionalscripts #21822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
approved these changes
Jul 13, 2020
|
New events should be documented in https://docs.nextcloud.com/server/19/developer_manual/app/events.html#available-events and old deprecations need to be added to #20953 |
|
Please also fix the CS complains :) |
This was referenced Jul 13, 2020
rullzer
force-pushed
the
enh/events/additionalscripts
branch
from
7f8d6b6 to
87d6d47
Compare
ChristophWurst
requested changes
Jul 14, 2020
lib/public/AppFramework/Http/Events/LoadAdditionalScriptsEvent.php
Outdated
Show resolved
Hide resolved
lib/public/AppFramework/Http/Events/LoadAdditionalScriptsLoggedInEvent.php
Outdated
Show resolved
Hide resolved
|
Let me push some fixup commits here and then we can continue the discussion :) |
|
@rullzer @ChristophWurst Give me your feedback :) |
MorrisJobke
approved these changes
Jul 15, 2020
kesselb
reviewed
Jul 15, 2020
lib/private/AppFramework/Middleware/AdditionalScriptsMiddleware.php
Outdated
Show resolved
Hide resolved
MorrisJobke
added
the
pending documentation
MorrisJobke
force-pushed
the
enh/events/additionalscripts
branch
2 times, most recently
from
201c8a4 to
6b5d76b
Compare
ChristophWurst
approved these changes
Jul 15, 2020
Signed-off-by: Roeland Jago Douma <[email protected]>
MorrisJobke
force-pushed
the
enh/events/additionalscripts
branch
from
6b5d76b to
7d7ba61
Compare
|
🚀 |
|
👍 from me |
|
#14552 to remove the legacy handler at some point in time. |
MorrisJobke
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make even more lazy loading possible!