-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Increase html body height to full content height" #22773
Revert "Increase html body height to full content height" #22773
Conversation
Fine with me, but what is the alternative for fixing all the actions menus then? I think it's not an option either to leave them broken nextcloud-libraries/nextcloud-vue#1384 |
Maybe something along the lines of this on the Actions?
|
That's basically why I came up with Let's see if someone else finds a better solution. 🙏 |
@nickvergessen With which version of Talk did you test it? On my production server (NC19.0.2 with Talk 9.0.3) nothing happens when I add |
Ok, on Chrome it creates issues. I only tested with Firefox so far. |
Well I tested with master of Talk on our Talk testing server.
Well you can specify another boundaries-element for those. you need to always specify it with the current parent as I understood it. |
The thing is, I didn't find a boundaries-element which properly works for vue as well as non-vue apps. And it has to work for both, as soon as you use the actions outside of a vue app container, e.g. as the status select popover. But I would be more than happy to be proven wrong 😅
I think I don't understand what you mean. |
Reverts #22614
Since quite some apps are published already, I think it's too late in the cycle for a breaking change like this