Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old user manager events for user creation #23901

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Deprecate old user manager events for user creation #23901

merged 1 commit into from
Nov 5, 2020

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 4, 2020 •
edited
Loading

@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Nov 4, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35032: failure

mariadb10.4-php7.4

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharesReshare
Failed asserting that '82' matches expected 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1423

@MorrisJobke MorrisJobke requested a review from skjnldsv November 5, 2020 07:37
@rullzer rullzer merged commit 12e2b74 into master Nov 5, 2020
@rullzer rullzer deleted the techdebt/noid/deprecate-old-usermanager-events branch November 5, 2020 08:37
@ChristophWurst
Copy link
Member

Good call. #23768 should make it clear on the caller side

@MorrisJobke MorrisJobke mentioned this pull request Nov 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@blizzz blizzz Awaiting requested review from blizzz

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @ChristophWurst @rullzer @skjnldsv