Skip instead of throwing on invalid DAV data migration #32466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
bug
3. to review
Pytal
requested review from
PVince81,
icewind1991 and
come-nc
and removed request for
a team
|
/backport to stable24 |
|
This means partial import/partial export when there are errors in the data. |
When invoked via the CLI then the message is displayed though from the web UI there is no mechanism to communicate these messages We could add a way for interface agnostic messages to be communicated or maybe something else if there's a better way, any further suggestions @come-nc? |
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
skjnldsv
approved these changes
Feb 23, 2024
skjnldsv
reviewed
Feb 23, 2024
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
skjnldsv
force-pushed
the
fix/skip-dav-migrator
branch
from
2e55cbf to
a770fd8
Compare
skjnldsv
added
4. to release
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering invalid data instead of failing we will skip it