do not display the buffer_size info if the size is already set to a c… #32902
Conversation
|
@MichaIng WDYT? :) |
szaimen
force-pushed
the
enh/noid/opcache-buffer-size-limit
branch
from
f617b4e to
cd3d7ce
Compare
|
Generally I agree that with the probably rare but existing (and summing) cases where the interned strings buffer seems to be used without limits by Nextcloud only, we need to mute the warning at some point. At least until someone finds time to deeper investigate under which circumstances or by which app this wasteful interned strings buffer usage is triggered. I however suggest to raise it to Not using a hardcoded value here would cover cases where other applications are used aside of Nextcloud on the same FPM pool. In this case, the OPcache may need to be raised above the default (never the case with Nextcloud only), and then a higher interned strings buffer also becomes more reasonable. The other way round I personally use only 64 MiB OPcache size with a small Nextcloud instance (also not many apps) and in this case 32 MiB interned strings (in my case ~3.5 MiB used only) doesn't seem to be reasonable, 16 MiB seem a better limit then for muting the warning. |
szaimen
force-pushed
the
enh/noid/opcache-buffer-size-limit
branch
from
cd3d7ce to
dd49c45
Compare
|
All right! then lets do it like suggested. Does this look good now? :) |
szaimen
requested review from
artonge,
a team,
blizzz,
skjnldsv and
CarlSchwan
and removed request for
a team
…ertain threshold Signed-off-by: szaimen <[email protected]> Co-Authored-By: MichaIng <[email protected]>
szaimen
force-pushed
the
enh/noid/opcache-buffer-size-limit
branch
from
700a47f to
f8bebb6
Compare
|
CI failure unrelated |
|
/backport to stable24 |
|
/backport to stable23 |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
Strange, the code line and lines around are identical on all three branches 🤔. |
|
lets try again |
|
/backport to stable24 |
|
/backport to stable23 |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely. This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched. Signed-off-by: MichaIng <[email protected]>
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely. This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched. Signed-off-by: MichaIng <[email protected]>
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely. This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched. Signed-off-by: MichaIng <[email protected]>
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely. This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched. Signed-off-by: MichaIng <[email protected]>
…ertain threshold
Signed-off-by: szaimen [email protected]