Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete notification container #33358

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Remove obsolete notification container #33358

merged 1 commit into from
Jul 26, 2022

Conversation

PVince81
Copy link
Member

The future is TOAST 🍞

  • grepped the Nextcloud release tarball for further usage: nothing found!
  • TEST: notifications app still works
  • TEST: "your storage is almost full" notification still works, it's using toastify already

✅ fixes accessibility issues by getting rid of duplicate ids in the DOM

@PVince81 PVince81 added this to the Nextcloud 25 milestone Jul 26, 2022
@PVince81 PVince81 self-assigned this Jul 26, 2022
@PVince81
Copy link
Member Author

/compile amend /

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 26, 2022
@PVince81 @nextcloud-command
Remove obsolete notification container
255d22f 
The future is TOAST 🍞

Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the techdebt/noid/remove-old-notification-container branch from 948f581 to 255d22f Compare July 26, 2022 13:54
@PVince81 PVince81 merged commit 1daf4de into master Jul 26, 2022
@PVince81 PVince81 deleted the techdebt/noid/remove-old-notification-container branch July 26, 2022 16:01
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@PVince81 PVince81

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility technical debt
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @nickvergessen @artonge @CarlSchwan