Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/vue from 5.3.1 to 5.4.0 #33467

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Aug 5, 2022

Ref: https://github.com/nextcloud/nextcloud-vue/releases/tag/v5.4.0

  • todo: recompile
  • smoke test
    • share panel
    • modal (file picker)
    • notification: close button is not right aligned any more ? => already on master
    • tooltip

@PVince81 PVince81 added the 3. to review Waiting for reviews label Aug 5, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 5, 2022
@PVince81 PVince81 self-assigned this Aug 5, 2022
@PVince81 PVince81 force-pushed the bump-nextcloud-vue-5.4.0 branch from d1f61be to a3e2c6e Compare August 5, 2022 15:26
@PVince81 PVince81 marked this pull request as ready for review August 5, 2022 15:27
@@ -4,28 +4,26 @@ exports[`CalDavSettings interactions 1`] = `
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this file should be shipped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, but it was there already and failing

@PVince81 PVince81 requested a review from Pytal August 10, 2022 20:11
Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 force-pushed the bump-nextcloud-vue-5.4.0 branch from 95843bf to 1018285 Compare August 10, 2022 20:25
@PVince81
Copy link
Member Author

rebased, rebuilt

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 11, 2022
@skjnldsv skjnldsv merged commit 2de3581 into master Aug 11, 2022
@skjnldsv skjnldsv deleted the bump-nextcloud-vue-5.4.0 branch August 11, 2022 06:47
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants