Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @nextcloud/vue to 7.2.0 #35717

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Bump @nextcloud/vue to 7.2.0 #35717

merged 1 commit into from
Dec 15, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 10, 2022

@Pytal Pytal added the 3. to review Waiting for reviews label Dec 10, 2022
@Pytal Pytal added this to the Nextcloud 26 milestone Dec 10, 2022
@Pytal Pytal self-assigned this Dec 10, 2022
@Pytal
Copy link
Member Author

Pytal commented Dec 10, 2022

/backport to stable25

szaimen
szaimen previously requested changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reintroduces #34777

nickvergessen
nickvergessen approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reopening of #34777 is an acceptable trade for me :)

@Pytal
Copy link
Member Author

Pytal commented Dec 12, 2022

This reintroduces #34777

Blocking or not @PVince81?

@Pytal
Copy link
Member Author

Pytal commented Dec 12, 2022

/compile amend /

PVince81
PVince81 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

@Pytal not blocking because then we can't progress on a11y if we don't merge this

still, I asked @skjnldsv to help with #34777

@Pytal @skjnldsv
Bump @nextcloud/vue to 7.2.0
b3afa74 
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv force-pushed the deps/nextcloud/vue-7.2.0 branch from 3b2fe9a to b3afa74 Compare December 15, 2022 08:51
@skjnldsv
Copy link
Member

Rebased and ready to merge

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 15, 2022
@skjnldsv skjnldsv merged commit c9dcf39 into master Dec 15, 2022
@skjnldsv skjnldsv deleted the deps/nextcloud/vue-7.2.0 branch December 15, 2022 09:48
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 15, 2022 •
edited by Pytal
Loading

The backport to stable25 failed. Please do this backport manually.

#35793

@Pytal Pytal mentioned this pull request Dec 16, 2022
Closed
This was referenced Jan 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen left review comments

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @PVince81 @skjnldsv @nickvergessen @szaimen