Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved display of app links #37823

Closed
wants to merge 4 commits into from
Closed

Improved display of app links #37823

wants to merge 4 commits into from

Conversation

Jerome-Herbinet
Copy link
Member

Signed-off-by: Jérôme Herbinet [email protected]

Before :

2023-04-19_14-41

After :

2023-04-19_14-41_1
2023-04-19_14-44

Checklist

@ChristophWurst ChristophWurst requested review from nimishavijay and jancborchardt and removed request for ChristophWurst and skjnldsv April 19, 2023 12:59
@ChristophWurst ChristophWurst added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 19, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 19, 2023
jancborchardt
jancborchardt requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jerome-Herbinet this looks a bit nonstandard, not an element we use anywhere else. What do you think about a simple list with the default bullet points on the left?

@Jerome-Herbinet
Copy link
Member Author

Jerome-Herbinet commented Apr 19, 2023 •
edited
Loading

@Jerome-Herbinet this looks a bit nonstandard, not an element we use anywhere else. What do you think about a simple list with the default bullet points on the left?

Or a simple line break like this? I'm afraid the little list bullets are visually distracting, as we're not in the description yet ? @jancborchardt
2023-04-19_16-25

@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@jancborchardt
Copy link
Member

@Jerome-Herbinet yep, simply adding line breaks already improves it a lot! :)

This was referenced May 9, 2023
Closed
Merged
@Jerome-Herbinet
Copy link
Member Author

@Jerome-Herbinet yep, simply adding line breaks already improves it a lot! :)

Done @jancborchardt :-)

@Jerome-Herbinet
Simple line breaks
fceb8cd 
Signed-off-by: Jérôme Herbinet <[email protected]>

Improved display of app links

Signed-off-by: Jérôme Herbinet <[email protected]>

Signed-off-by: Jérôme Herbinet <[email protected]>

npm run build

Signed-off-by: Jérôme Herbinet <[email protected]>
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-apps-patch-1 branch from 0161e15 to fceb8cd Compare May 9, 2023 08:43
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

conflicts

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 30, 2023
@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

@Jerome-Herbinet can you please rebase and commit the compile js again? Sorry for the inconvenience!

@Jerome-Herbinet Jerome-Herbinet mentioned this pull request May 30, 2023
Merged
4 tasks
@Jerome-Herbinet
Copy link
Member Author

New PR #38520

@szaimen szaimen removed this from the Nextcloud 28 milestone May 30, 2023
@szaimen szaimen deleted the Jerome-Herbinet-apps-patch-1 branch May 30, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt requested changes

@nimishavijay nimishavijay nimishavijay approved these changes

Assignees
No one assigned
Labels
2. developing Work in progress design Design, UI, UX, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jerome-Herbinet @jancborchardt @szaimen @nimishavijay @ChristophWurst @blizzz