-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance template picker size and layout depending on aspect ratio #38174
Conversation
cc @nickvergessen As i noticed that talk has a similar picker implementation on its own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Fine by me then but didnt test
However the buttons to confirm and cancel being so far apart on the left and right looks kind of strange to me... |
Thanks for the ping, added a talk issue for tracking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, very good idea @juliushaertl! 👍 as discussed! :)
However the buttons to confirm and cancel being so far apart on the left and right looks kind of strange to me...
@szaimen yeah, although I wouldn’t put them directly next to each other either. Rather we could remove the Cancel button since there is already an X close on the top right. We also don’t have a "Cancel" in the Move/Copy dialog for example.
Good point |
Signed-off-by: Julius Härtl <[email protected]>
0ca8742
to
032e3d3
Compare
Adapt the template picker modal size to large to take more use of screen when available and adapt the sizing of the previews to be
Summary
Checklist