Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22] check the username when doing external storage session auth #38285

Merged
merged 1 commit into from
May 15, 2023
Merged

[22] check the username when doing external storage session auth #38285

merged 1 commit into from
May 15, 2023

Conversation

icewind1991
Copy link
Member

Backport of #38265

github-advanced-security[bot]
github-advanced-security bot found potential problems May 15, 2023
View reviewed changes
apps/files_external/lib/Lib/Auth/Password/SessionCredentials.php
@@ -57,6 +58,10 @@
throw new InsufficientDataForMeaningfulAnswerException('No session credentials saved');
}

if ($credentials->getUID() !== $user->getUID()) {

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method getUID on possibly null value
@icewind1991 icewind1991 merged commit 86e4f32 into stable22 May 15, 2023
@icewind1991 icewind1991 deleted the session-auth-check-username-22 branch May 15, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @artonge @come-nc