Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle more exceptions in AmazonS3::fopen #39367

Merged
merged 2 commits into from
Jul 20, 2023
Merged

handle more exceptions in AmazonS3::fopen #39367

merged 2 commits into from
Jul 20, 2023

Conversation

icewind1991
Copy link
Member

returning false instead of throwing is the expected behavior.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 13, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Jul 13, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, nfebe and come-nc and removed request for a team July 13, 2023 13:40
@icewind1991 icewind1991 mentioned this pull request Jul 13, 2023
Merged
4 tasks
@icewind1991
Copy link
Member Author

Other failing external storage tests

  • vsftpd is a docker related issue
  • kerberos sso is "complicated" and probably needs adjustments to the scripted setup

@icewind1991 icewind1991 merged commit 31f1ff8 into master Jul 20, 2023
@icewind1991 icewind1991 deleted the s3-fopen-exception branch July 20, 2023 17:32
@icewind1991
Copy link
Member Author

/backport to stable27

@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Mar 27, 2024
@nextcloud nextcloud deleted a comment from kesselb Mar 27, 2024
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Mar 27, 2024
@backportbot backportbot bot mentioned this pull request Mar 27, 2024
Merged
3 tasks
@icewind1991 icewind1991 mentioned this pull request Mar 27, 2024
Closed
@icewind1991
Copy link
Member Author

/backport to stable26

@backportbot backportbot bot mentioned this pull request Mar 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @Pytal @come-nc