-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Improve shared status button" #42041
Conversation
This reverts commit c2c5994.
I'll have a look with the design team to make sure we keep the previous issue fixed too |
Aside from the execution, admittedly poor and rushed, I just want to register that I did this reluctantly and didn't agree much with the set of changes proposed for this button. Nor with how fast they were rushed in without exploring other solutions. |
All good, Marco :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look with the design team to make sure we keep the previous issue fixed too
Could we make sure that we don’t revert it without addressing that part here already?
The specification / mockup exists at #37208, and as long as design-wise it looks like that, you are expert regarding implementation. :)
What about this PR, it appears stale? |
This reverts commit c2c5994.
Sorry @marcoambrosini, I cannot approve the previous PR:
I'll have a look with the design team to make sure we keep the previous issue fixed too