-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IAppConfig] format values based on type #43258
Conversation
56af4d1
to
83b4b44
Compare
83b4b44
to
cf673bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
16273db
to
58c6124
Compare
58c6124
to
b984382
Compare
b984382
to
0443c8f
Compare
0443c8f
to
d84954c
Compare
43338de
to
a697c94
Compare
I have found a performance issue as this PR would load lazy config values when searching for the enabled apps at boot. Adding also a test to confirm that no lazy config values are loaded during the normal boot of Nextcloud |
a697c94
to
0cf37c8
Compare
|
Signed-off-by: Maxence Lange <[email protected]>
0cf37c8
to
a667224
Compare
test was not related to the PR. I will implement it in a separated PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have liked this covered in Tests before we get this in
returns formated values based on type when calling
getAllValues()
andsearchValues()
note: deprecated method
getValues()
usegetAllValues()
but if the config value is defined as MIXED (default), the value is kept as a string.original:
new: