Fixes for getting the filename in the FileInfo class #43652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopleus
force-pushed
the
bugfix/fixed-get-filename-in-fileinfo
branch
from
855e56e to
b02abe6
Compare
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
solracsf
requested review from
a team,
icewind1991,
nfebe and
sorbaugh
and removed request for
a team
…s received, but it is empty Signed-off-by: hopleus <[email protected]>
hopleus
force-pushed
the
bugfix/fixed-get-filename-in-fileinfo
branch
from
b02abe6 to
1c085a9
Compare
|
@solracsf Hi. Could you run the tests again? P.S. Last time cypress crashed with 503 errors and I didn't understand why |
icewind1991
approved these changes
Mar 8, 2024
Merged
Altahrim
reviewed
Mar 12, 2024
Signed-off-by: hopleus <[email protected]>
Altahrim
approved these changes
Mar 13, 2024
Merged
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes for getting the filename in the case when the file name key is received, but it is empty.
P.S. Faced with such a problem with ObjectStore enabled in S3 mode
Checklist