-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add back searching in disabled user list #45370
Conversation
Implemented.
I think this is fine, because a class implementing the interface for 30 also implements the one for 28.0.0, as it’s only a new parameter. |
/compile / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer separate methods for searching quite a lot over changing the behavior of the existing methods. Would that be possible or is it too much work or impractical?
Ok in light of the discussion in #44936 it makes sense to extend the existing endpoint instead of creating a new one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So BC is not a real BC?
Edit: seen your second comment
When disabled users where moved to their own endpoint we overlooked search, so adding it back. The search is done case-insensitive in uid and display name. Signed-off-by: Côme Chilliet <[email protected]>
To match what is done for Database backend for enabled users Signed-off-by: Côme Chilliet <[email protected]>
bfde1f7
to
0505a1f
Compare
/compile / |
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
e5c0dbb
to
9a523e9
Compare
/backport to stable29 |
/backport to stable28 |
Summary
When disabled users where moved to their own endpoint we overlooked search, so adding it back.
The search is done case-insensitive in uid and display name.
TODO
Checklist