fix(settings): Fix mail server settings form #50046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
a team,
susnux,
artonge and
sorbaugh
and removed request for
a team
|
/backport to stable30 |
|
/backport to stable29 |
4 tasks
skjnldsv
approved these changes
Jan 7, 2025
Merged
Merged
susnux
approved these changes
Jan 14, 2025
|
/compile |
|
/compile rebase |
Signed-off-by: provokateurin <[email protected]>
|
Building locally... wait for it |
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
fix/settings/mail-server-settings-form
branch
from
172248d to
ce5cbd8
Compare
|
That would have been my next attempt, but I always end up with different compiled assets than CI so I try to avoid it 🙈 |
This was referenced Jan 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found while testing for #49891.
With the JQuery ajax the request fails the CSRF checks so the settings are never saved.
In addition to that the form didn't display the error messages correctly.
I'm not sure how long this problem has existed, I would have expected that we received some bug reports about it, but I couldn't really find anything.
There are some other places where we still use JQuery ajax and those could be broken as well, but I didn't test them.
Checklist