feat(cardav): support result truncation for addressbook federation #50092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
3. to review
hamza221
force-pushed
the
feat/sync-truncation
branch
from
c7ee3ab to
1cb4891
Compare
st3iny
reviewed
Jan 14, 2025
| @@ -851,6 +855,10 @@ public function deleteCard($addressBookId, $cardUri) { | |||
| * @return array | |||
| */ | |||
| public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel, $limit = null) { | |||
| if ($limit === null) { | |||
| $limit = $this->config->getSystemValueInt('carddav_sync_request_limit', 1); | |||
There was a problem hiding this comment.
TODO: Debugging leftover has to be removed (default limit 1) before the merge.
hamza221
added
feature: carddav
The limit is set to 1 here. The ways to test this that I can think of
PS: In case of federation both instances need to be patched.
It should work for client sync too, But testing server to server is also needed to cover the whole PR |
Signed-off-by: Hamza Mahjoubi <[email protected]>
…tion Signed-off-by: Hamza Mahjoubi <[email protected]>
…tion Signed-off-by: Hamza Mahjoubi <[email protected]>
…tion Signed-off-by: Hamza Mahjoubi <[email protected]>
…tion Signed-off-by: Hamza Mahjoubi <[email protected]>
AndyScherzinger
force-pushed
the
feat/sync-truncation
branch
from
64d8d2d to
2e2983a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist