fix(setupcheck): Update setup check for PHP version to be more accurate #50735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable31 |
|
/backport to stable30 |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/bump-php-dependency-update-versions
branch
from
bef5b6b to
c3fc42e
Compare
susnux
reviewed
Feb 8, 2025
| @@ -29,7 +34,13 @@ public function getName(): string { | |||
|
|
|||
| public function run(): SetupResult { | |||
| if (PHP_VERSION_ID < 80200) { | |||
| return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP 8.1 is now deprecated in Nextcloud 30. Nextcloud 31 may require at least PHP 8.2. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [PHP_VERSION]), 'https://secure.php.net/supported-versions.php'); | |||
| return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP %s is deprecated since Nextcloud %d. Nextcloud %s may require at least PHP %s. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [ | |||
There was a problem hiding this comment.
Suggested change
| return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP %s is deprecated since Nextcloud %d. Nextcloud %s may require at least PHP %s. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [ | |
| return SetupResult::warning($this->l10n->t('You are currently running PHP %1$s. PHP %2$s is deprecated since Nextcloud %3$d. Nextcloud %4$s may require at least PHP %5$s. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [ |
There was a problem hiding this comment.
Two placeholders in one sentence seems risky to me without positional placeholders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite this being a language change, I'd still backport it, to avoid confusion before and during updates.
Should also backport to 30 and 31
Checklist