Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wipe local storages on log out #50956

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

Antreesy
Copy link
Contributor

Summary

If session was determined as 'terminated', it makes sense to clear local storages (to not interfere with the next login, and to wipe any sensitive information)

Checklist

@Antreesy Antreesy added this to the Nextcloud 32 milestone Feb 21, 2025
@Antreesy Antreesy self-assigned this Feb 21, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be enough to only adjust the target which will do it automatically, so we do not duplicate the clearing logic.

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with that approach :)

@Antreesy Antreesy force-pushed the fix/noid/wipe-local-storage branch from 745bcaf to afd27f4 Compare February 24, 2025 09:38
@Antreesy
Copy link
Contributor Author

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy merged commit 21eb6d5 into master Feb 24, 2025
121 checks passed
@Antreesy Antreesy deleted the fix/noid/wipe-local-storage branch February 24, 2025 10:49
@Antreesy
Copy link
Contributor Author

/backport afd27f4 to stable31

@Antreesy
Copy link
Contributor Author

/backport afd27f4 to stable30

@Antreesy
Copy link
Contributor Author

/backport afd27f4 to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants