fix(files_reminders): Do not attempt to send reminders after a user has left a share #51079
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as left a share Signed-off-by: Christopher Ng <[email protected]>
Pytal
added
bug
3. to review
Pytal
requested review from
icewind1991,
artonge and
nfebe
and removed request for
a team
|
/backport to stable31 |
nickvergessen
approved these changes
Feb 27, 2025
artonge
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In cases where a user is shared a file and leaves the share or the file becomes unshared, the notification remains and will attempt to be resent continually
This makes sure that the notification is properly deleted
Checklist