[stable28] feat: Close sessions created for login flow v2 #51087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
bug
3. to review
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser. This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request. Signed-off-by: Louis Chemineau <[email protected]> [skip ci] Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
backport/51051/stable28
branch
from
112b585 to
716b081
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
approved these changes
Mar 3, 2025
artonge
added
4. to release
artonge
force-pushed
the
backport/51051/stable28
branch
from
afae0d8 to
61f3bbc
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
backport/51051/stable28
branch
from
61f3bbc to
f284df0
Compare
AndyScherzinger
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #51051
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.