Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serverinfo representation in nextcloud OCC command tool: add info… #743

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acomdigital
Copy link

This PR adds a new OCC command, as described in issue #190, to retrieve serverinfo data.
Fixes #190

Changes Made:

  • Added occ command php occ serverinfo:info;
  • Encapsulated some business logic of ApiController into a dedicated service layer

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@kesselb
Copy link
Collaborator

kesselb commented Feb 12, 2025

Thanks for your pull request 👍

Sorry, I didn't have the opportunity to review it.

  • DCO, Linter and Tests are failing.
  • I'm unsure about adding another service to wrap the other services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serverinfo representation in nextcloud OCC command tool
2 participants