Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for teams in usergroup column #1326

Open
wants to merge 7 commits into
base: share-with-teams
Choose a base branch
from
Open

feat: add support for teams in usergroup column #1326

wants to merge 7 commits into from

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Aug 29, 2024

Fixes #1304

@enjeck enjeck self-assigned this Aug 29, 2024
@enjeck enjeck added the 2. developing Work in progress label Aug 29, 2024
@juliusknorr juliusknorr added the enhancement New feature or request label Aug 29, 2024
@enjeck enjeck force-pushed the feat/1304 branch 2 times, most recently from cced61d to a4cf3b0 Compare September 4, 2024 07:43
@enjeck enjeck marked this pull request as ready for review September 4, 2024 07:43
@enjeck enjeck added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 4, 2024
@enjeck
Copy link
Contributor Author

enjeck commented Sep 4, 2024

Demo

2024-09-04_08-24-21.mp4

@enjeck enjeck force-pushed the feat/1304 branch 2 times, most recently from 98fa8eb to daed40a Compare October 2, 2024 15:08
@enjeck enjeck force-pushed the feat/1304 branch 2 times, most recently from a2bb27a to 42b32dc Compare October 23, 2024 18:08
@enjeck
Copy link
Contributor Author

enjeck commented Dec 5, 2024 •
edited
Loading

TODO:

  • Hide Teams option if app is disabled

@hweihwang
share with teams
68c2920 
Signed-off-by: Hoang Pham <[email protected]>
@enjeck enjeck marked this pull request as draft December 29, 2024 11:52
@enjeck
Copy link
Contributor Author

enjeck commented Dec 29, 2024 •
edited
Loading

This relies on #142 to provide the isCirclesEnabled functionality. So I'm changing the base branch.

@enjeck enjeck changed the base branch from main to share-with-teams December 29, 2024 11:58
@enjeck enjeck marked this pull request as ready for review December 30, 2024 05:50
@hweihwang hweihwang force-pushed the share-with-teams branch 3 times, most recently from ad53267 to 5dacb82 Compare January 7, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@elzody elzody Awaiting requested review from elzody

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees

@enjeck enjeck

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
📝 Office team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for teams in the user/group column
4 participants
@enjeck @blizzz @juliusknorr @hweihwang