-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Contexts): add Contexts to navigation when applicable #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment otherwise looks straight forward
d72b46b
to
5660cf7
Compare
47729eb
to
2feda37
Compare
1a4fcd2
to
f45d956
Compare
2feda37
to
79b549f
Compare
76d64d3
to
dd896ac
Compare
a91c25b
to
10c1c97
Compare
10c1c97
to
11548e5
Compare
11548e5
to
84622c6
Compare
@enjeck what would be a nice addition is that the appropriate nav bar icon is set active, when being on an application that has an entry there (otherwise going back to tables). |
84622c6
to
e7dddcb
Compare
I think this is tricky to do on the frontend. We may need a separate backend route to still render the TemplateResponse but then set the active entry on the navigation manager. We can then set an initial state that indicates that we're on an application page and to further adjustments on the frontend side like hiding the navigation by default. Something for a follow up I'd say. |
Signed-off-by: Arthur Schiwon <[email protected]>
e7dddcb
to
84606ad
Compare
Ah, I was speculating that such an option exist for fronted, but of course… why would it. There was no similar case before. Follow up is fine +1 |
solves #863
needs #903 (soft)
wants nextcloud/server#44178Screenshot made with frontend from #844. On the content area in the UI we don't render the material icons yet, but the icon is in the nav bar. The icon over the mouse pointer is material design, while the two icons on the very right have fallback icons (default app icon).