chore: update Build-in Talk script and CI #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShGKme
commented
Jan 24, 2025
•
ShGKme
commented
ShGKme
force-pushed
the
chore/update-built-in-Talk
branch
7 times, most recently
from
fd5ccd5 to
33a18d3
Compare
ShGKme
force-pushed
the
chore/update-built-in-Talk
branch
2 times, most recently
from
767530d to
634fab2
Compare
SystemKeeper
requested changes
Jan 24, 2025
| run: echo "${{ steps.update.outputs.stdout }}" | ||
|
|
||
| - name: Create Pull Request | ||
| if: steps.update.outcomes == 'success' |
There was a problem hiding this comment.
Suggested change
| if: steps.update.outcomes == 'success' | |
| if: steps.update.outcome == 'success' |
There was a problem hiding this comment.
Also is there any error case? So if no changes are found, it would still create a PR? (Just asking)
There was a problem hiding this comment.
Also is there any error case?
No as far as I know
So if no changes are found, it would still create a PR? (Just asking)
Checked by peter-evans/create-pull-request
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed with force-push, 1 char changed
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
chore/update-built-in-Talk
branch
from
634fab2 to
ce851b6
Compare
SystemKeeper
approved these changes
Jan 24, 2025
|
Thanks, @SystemKeeper ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.